Topic: Add comment or rating with Yabb auth. in 6.5 ?!

[htilly]

Hi !

First off..  Lovely to see a new release of this great script.. Even better to see that you are working on a PHP version !!!
Now, anyhow.. I do have a strange problem.

If Im not logged in and I try to add a rating it will tell me:
"Must be loggen in to add rating"..  Sure.. fine..

BUT if I log in as admin, and try the same thign (using MySQL Yabb auth.)
It tells me:
"Guesst can not add ratings" 
So.. two questions:

1:
How do I enable guest to add ratings.

2:
Why can´t I add rating when logged in as admin ?!

Once again... thansk for a great script !!

BR
Tilly

[frister]

Are you running one of the  two latest releases? Ver. 6.5 Release 11 or Release 12? I remember we had a bug like that before 11.
I've tested mine with flatfile, YaBB, MySQL database, and my modified AccountMananger authentication methods, and the only way I can get the error message you list is if my admin name is also included in the default_guests list.

J.J.

[htilly]

Version 6.5 (Frister [12] Release) written by Mike Bobbitt.
With modifications by J.J. Frister

But I found the problem...  Don’t know why, but for some reason the config field: db_displaynamefield, was left empty. To be honest, I think is always has been empty 

Anyhow..  I can now reproduce the problem. If the field is left empty I can login etc. but are unable to add ratings.

Everything is back on track 

Oho.. btw..  THANKS Frister for all new improvements and help you have given Mike and this project !!   
+applaud

[frister]

Glad you found it. Thanks for the tip about displaynamefield.  And thanks for the applause, glad you like the changes. Just a bunch of stuff I wanted to use and thought others might also.

J.J.

[frister]

Mike, here's the fix for the problem Tilly found in my code:

Code: [Select]

# Fetch Rows
while(@row=$sth->fetchrow_array)
{
$storedpass=$row[0];
debug("\$row[0]=$storedpass",2,__LINE__);

$maybedisplayname=$row[1];
debug("\$row[1]=$maybedisplayname",2,__LINE__);

if ($maybedisplayname)
{
$::displayname=$maybedisplayname;
}
$::mem_level=2;
}I had set $::memlevel only if the displayname was found, instead of just finding the member.
J.J.

[Mike Bobbitt]

Awesome. Updated the zip file.

[htilly]

Final question on this topic:

How can I enable guest to add Comments 

BR
Tilly

[frister]

Comment out or delete these lines from album.pl:

Code: [Select]

elsif (isGuest() && $::authentication_type)
{
require $::display_module;
display(javaAlert("Guests can not add ratings!"));
$::function="";
}
User must still log in.
J.J.

[htilly]

I don´t get it  :'(

If I comment out theese lines, the user still must be logged in ?

Is there anyway to let visiting users just hit the Rating button and submit a comment...  Without login at all, the way it worked in the previous version ?

BR
Tilly

Comment out or delete these lines from album.pl:

Code: [Select]

elsif (isGuest() && $::authentication_type)
{
require $::display_module;
display(javaAlert("Guests can not add ratings!"));
$::function="";
}
User must still log in.
J.J.

[htilly]

Hmm..  maybe I figure it out... Seems to work with this settings:

        my $temp=$form->param('rating_file_loc');
#               if(!$::loggedin && $::authentication_type)
#               {
#                       require $::display_module;
#                       display(javaAlert("Must be logged in to add ratings!"));
#                       $::function="";
#               }
#               elsif (isGuest() && $::authentication_type)
#               {
#                       require $::display_module;
#                       display(javaAlert("Guests can not add ratings!"));
#                       $::function="";
#               }
#               else
#               {
                        openDescfile("$::album_dir/$temp/");
                        getDescription($form->param('object'));
                        $::shortdesc="$::S{229} ".$::shortdesc;
                        require $::display_module;
                        display(buildTemplate());
                        exit(0);
#               }
        }


Feature request:
Add this as a config item: Enable Guest to add comments ?!

BR
Tilly

I don´t get it  :'(

If I comment out theese lines, the user still must be logged in ?

Is there anyway to let visiting users just hit the Rating button and submit a comment...  Without login at all, the way it worked in the previous version ?

BR
Tilly

[frister]

Good work! Those look like exactly the right lines to comment out. 

J.J.