« previous next »
Pages: [1]   Go Down

Author Topic: html error?  (Read 3889 times)

0 Members and 1 Guest are viewing this topic.

Offline AllenAyres

  • album.pl Contributor
  • ***
  • Posts: 61
  • Karma: +0/-0
  • I didn't forget to change the default text.
html error?
« on: November 14, 2002, 16:46:21 »
http://www.ubbdev.com/cgi-bin/album.pl

Using the code from a couple hours ago, It looks like we've got an extra </td> in there I believe, if you do a 'view source' on the album.pl page, ~line #307 we have:

<!-- PAGES tag end -->
</p></td>

<!-- FILE

I think that </td> is in the wrong place, tho I can't figure out where it is in the code  ???

I am hoping that's the only spot and it's an easy find :)
« Last Edit: December 31, 1969, 19:00:00 by 1039064400 »
Logged

Offline AllenAyres

  • album.pl Contributor
  • ***
  • Posts: 61
  • Karma: +0/-0
  • I didn't forget to change the default text.
Re: html error?
« Reply #1 on: November 14, 2002, 16:47:55 »
looks pretty bad in mozilla ;)
« Last Edit: December 31, 1969, 19:00:00 by 1039064400 »
Logged

Offline AllenAyres

  • album.pl Contributor
  • ***
  • Posts: 61
  • Karma: +0/-0
  • I didn't forget to change the default text.
Re: html error?
« Reply #2 on: November 14, 2002, 17:42:10 »
Here's a buglet:

album.pl - line # 3200, there's an extra </td> there

not related to the previously mentioned bug :)
« Last Edit: December 31, 1969, 19:00:00 by 1039064400 »
Logged

Offline AllenAyres

  • album.pl Contributor
  • ***
  • Posts: 61
  • Karma: +0/-0
  • I didn't forget to change the default text.
Re: html error?
« Reply #3 on: November 14, 2002, 17:47:25 »
Moving the form tags outside the table tags at ~lines #3080 and #3215 cure a few ills in there as well :)
« Last Edit: December 31, 1969, 19:00:00 by 1039064400 »
Logged

Offline AllenAyres

  • album.pl Contributor
  • ***
  • Posts: 61
  • Karma: +0/-0
  • I didn't forget to change the default text.
Re: html error?
« Reply #4 on: November 14, 2002, 18:38:13 »
Here's my album.pl and albumstrings file with the few little html changes/corrections if you are interested:

http://ubbdev.com/cgi-bin/album.zip

I updated the doctype to the full doctype and now the browser interprets it strictly, aligning everything down the middle  :o When I put the short one back in, it goes into 'quirks' mode and looks ok in IE, but mozilla still runs everything down the middle  ::)
« Last Edit: December 31, 1969, 19:00:00 by 1039064400 »
Logged

Offline AllenAyres

  • album.pl Contributor
  • ***
  • Posts: 61
  • Karma: +0/-0
  • I didn't forget to change the default text.
Re: html error?
« Reply #5 on: November 14, 2002, 18:39:44 »
mozilla does it here on the sample album too  :-/
« Last Edit: December 31, 1969, 19:00:00 by 1039064400 »
Logged

Offline Mike Bobbitt

  • album.pl Author
  • Administrator
  • I Spend Too Much Time Here
  • *****
  • Posts: 3381
  • Karma: +35/-2
    • Mike's Development Archive
Re: html error?
« Reply #6 on: November 15, 2002, 06:59:57 »
Hey thanks Allen, I really appreciate the help. The HTML is pretty "dirty" in places still, and I have to make a concerted effort to get it. Thanks for picking out the probs though... When I try to download your updated script, I get:

Quote
Page Unavailable
 
There was an error loading this page. Please contact the webmaster of this site.


I'll keep checking.

My eventual goal is to get rid of all tables, since they're just too confusing for a simple guy like me. :)

Cheers
« Last Edit: December 31, 1969, 19:00:00 by 1039064400 »
Logged

Offline AllenAyres

  • album.pl Contributor
  • ***
  • Posts: 61
  • Karma: +0/-0
  • I didn't forget to change the default text.
Re: html error?
« Reply #7 on: November 15, 2002, 10:55:58 »
You are welcome :) I can help more once I get the hang of the div's :)

http://ubbdev.com/album.zip

If you can find where that extra </td> is hiding, I'll be ever grateful :)
« Last Edit: December 31, 1969, 19:00:00 by 1039064400 »
Logged

Offline Mike Bobbitt

  • album.pl Author
  • Administrator
  • I Spend Too Much Time Here
  • *****
  • Posts: 3381
  • Karma: +35/-2
    • Mike's Development Archive
Re: html error?
« Reply #8 on: November 15, 2002, 16:53:55 »
Hi Allen,

Thanks for the update. I've merged your changes into the code, but when I vew my album in IE6, it puts all the thumbnails in a single vertical column. :( It's definitely a side effect of the "http://www.w3.org/TR/html4/loose.dtd" as it goes away when I take it out... Any ideas?

Thanks

P.S. I *think* the bogus </td> is in your album.tml file. Try updating all your templates (they now have comments too ;)) and see if it goes away...
« Last Edit: December 31, 1969, 19:00:00 by 1039064400 »
Logged

Offline AllenAyres

  • album.pl Contributor
  • ***
  • Posts: 61
  • Karma: +0/-0
  • I didn't forget to change the default text.
Re: html error?
« Reply #9 on: November 15, 2002, 23:51:03 »
Thank you :)

I'll give it a shot now. The doctype is sending the browsers into strict mode. I'll see if I can figure out how to get it working correctly if you don't first :)
« Last Edit: December 31, 1969, 19:00:00 by 1039064400 »
Logged

Offline AllenAyres

  • album.pl Contributor
  • ***
  • Posts: 61
  • Karma: +0/-0
  • I didn't forget to change the default text.
Re: html error?
« Reply #10 on: November 16, 2002, 00:04:58 »
Yay, that fixed whatever was messed up :D

I'll stay updated on the code and send you the zips if I see any buglets :)
« Last Edit: December 31, 1969, 19:00:00 by 1039064400 »
Logged

Offline Mike Bobbitt

  • album.pl Author
  • Administrator
  • I Spend Too Much Time Here
  • *****
  • Posts: 3381
  • Karma: +35/-2
    • Mike's Development Archive
Re: html error?
« Reply #11 on: November 16, 2002, 05:18:42 »
Thanks, I *really* appreciate the bugfixes!

I'll try to figure out what's going wrong with the strict doctype... Do you know offhand whether strict supports display: inline; ?

If not, that'd explain it. I use multiple <div>'s on the same line and show them inline, with a combined width of [nearly] 100%. (I.E. The photos are displayed in a row of 5 inline <div>'s with a width of 19% to make them look like a table...)

Something with that concept doesn't work with strict checking. (You may notice I don't use strict PERL checking in album.pl either - always wanted too, but it seems like too much work!  ;D)
« Last Edit: December 31, 1969, 19:00:00 by 1039064400 »
Logged

Offline AllenAyres

  • album.pl Contributor
  • ***
  • Posts: 61
  • Karma: +0/-0
  • I didn't forget to change the default text.
Re: html error?
« Reply #12 on: November 17, 2002, 23:33:57 »
http://ubbdev.com/album.zip updated with a few more small html fixes. I figure if we get it completely compliant it wil make tracking down the alignment issues much easier :)

That 'div tag inside an a tag' error wil be a little tricky to fix, since it's used in multiple instances, fixing one might impinge on a few others.
« Last Edit: December 31, 1969, 19:00:00 by 1039064400 »
Logged

Offline Mike Bobbitt

  • album.pl Author
  • Administrator
  • I Spend Too Much Time Here
  • *****
  • Posts: 3381
  • Karma: +35/-2
    • Mike's Development Archive
Re: html error?
« Reply #13 on: November 18, 2002, 05:29:35 »
Excellent. Your changes are now merged into the code stream, thanks!
« Last Edit: December 31, 1969, 19:00:00 by 1039064400 »
Logged
Pages: [1]   Go Up
« previous next »